Subject: Re: Segfault opening footer.abw
From: Dom Lachowicz (cinamod@hotmail.com)
Date: Sun Nov 12 2000 - 11:24:47 CST
Since we don't enable headers/footers and do import word documents, I'd be
loathe to reverse this patch. Besides, headers and footers aren't even well
implemented yet, to the best of my knowledge.
However, with this patch, I've imported 101 page word documents with almost
no problems. I think that this code/hack should stay in until at least after
0.7.12 is released.
Dom
>From: Martin Sevior <msevior@mccubbin.ph.unimelb.edu.au>
>To: Sam TH <sam@uchicago.edu>
>CC: Matt Brubeck <mbrubeck@hmc.edu>, AbiWord list
><abiword-dev@abisource.com>
>Subject: Re: Segfault opening footer.abw
>Date: Sun, 12 Nov 2000 23:12:05 +1100 (EST)
>
>
>
>On Sun, 12 Nov 2000, Sam TH wrote:
> >
> > Culprit found. The breakage appeared, AFAICT, after Martin's checkin
> > on the 27th of October. This was a fix for missing last lines in
> > Word documents. Sadly, the patch he applied will not reverse currently.
> > So we have to figure out why it broke footer import.
> >
> > The email he sent was:
> > http://www.abisource.com/mailinglists/abiword-dev/00/October/0380.html
> >
>
><Sigh> that was more a work around than fix. It works well too. I'd be
>loath to take that code out now since a large class of Word documents now
>load correctly as do multi-level lists. Since footers are not yet enabled
>I suggest we leave this code in for 0.7.12 and fix it properly for the
>next release which should have headers/footers enabled. I must admit I
>didn't think to check headers/footers and I can well imagine that the code
>would break them. Basically I check to see if a current or previous block
>has a valid m_pLastLine. If not I do a pBlock->format() on it. This is
>just plastering over a problem though. Every block should have a valid
>m_pFirstLine and m_pLastLine including header/footer blocks.
>
>This was bugger to track down and I gave up after the pBlock->format()
>worked-around the problem.
>
>Of course I'd love to see a proper fix which is that after importing every
>block should ALWAYS have a valid m_pFirstLine and m_pLastLine.
>
>Martin
>
>
>
_________________________________________________________________________
Get Your Private, Free E-mail from MSN Hotmail at http://www.hotmail.com.
Share information about yourself, create your own public profile at
http://profiles.msn.com.
This archive was generated by hypermail 2b25 : Sun Nov 12 2000 - 11:24:59 CST