Subject: Re: Code Cleanup
From: Thomas Fletcher (thomasf@qnx.com)
Date: Wed Jan 17 2001 - 11:31:54 CST
On Wed, 17 Jan 2001, Thomas Briggs wrote:
>
> This patch looks good, compiles ok and seems to work for me on Windows.
> Anybody in the Unix world wanna test this out or should I just go ahead and
> commit it?
I read through the patch and it seemed fine to me ... but I haven't had
a chance to apply it ... though when it is applied I'll have to fix the
QNX build (in the future if something like this changes I'd appreciate
just sticking a #error "Update me!" in the code to guarantee the update).
> Hrmm... actually, I did just find a problem, though I doubt it has
> anything to do with this patch.
>
> 1. Open a document
> 2. Set the zoom to 'Width'
> 3. Maximize the Windows
>
> Abi pretty much freezes. Not good.
>
> Can anybody confirm this anywhere else, particularly on a non-Win32
> system?
Doesn't happen on QNX ... empty document or full? Debug or non-debug?
Thomas
> ----- Original Message -----
> From: "Michael D. Pritchett" <mpritchett@attglobal.net>
> To: "Abi Patches" <patches@abisource.com>; "Abi Developer"
> <abiword-dev@abisource.com>
> Sent: Tuesday, January 16, 2001 10:33 PM
> Subject: Code Cleanup
>
>
> > This has been bugging me since I submitted the Dynamic Zoom patches. I
> knew
> > there had to be a way to impliment the feature without breaking the xap/ap
> > separation in the build. After stewing on it for a while it hit me. As a
> > result I am submitting this patch. Additionally, it cleans up the code
> > written.
> >
> > It has been tested on both Windows and Linux builds and I don't beleive it
> > breaks anything for BeOS or QNX.
> >
> > Cheers!
> >
> > Michael D. Pritchett
> >
>
>
-------------------------------------------------------------
Thomas (toe-mah) Fletcher QNX Software Systems
thomasf@qnx.com Neutrino Development Group
(613)-591-0931 http://www.qnx.com/~thomasf
This archive was generated by hypermail 2b25 : Wed Jan 17 2001 - 11:32:49 CST