Subject: commit: Re: commit: Menu Strings stored in .strings
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Tue Oct 30 2001 - 20:19:04 CST
HI Micheal,
I agree with the sentiment of this commit but there is an
important detail we've got to consider.
Dynamic menu Labels used to work by creating an entire copy of the menu's
stored in memory. We needed to do this because the old menu's were deleted
upon closing a frame. I think this is still the way to go because
otherwise menus and lables in widgets may get out of synch with the XP
menus and labels stored at the XAP_App level.
Given this we need to modify you label code to return a copy of the stored
label set with the GenerateLabelSet method.
This is what this commit does. Less than 1 LOC coz the original author
woz so smart :-)
Aiksaurus loads now.
Cheers!
Martin
CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: src/wp/ap/xp/ap_Menu_Layouts.cpp
CVS: ----------------------------------------------------------------------
return a copy of the label set in CreateMenuLabelSet
On Tue, 30 Oct 2001, Michael D. Pritchett wrote:
> This is a major modification of how we handle menu strings. Strings for
> menus (label and statusline) are now located in string list. Instead of
> carrying these strings in the code, they will be loaded from the .strings
> files. This reduces code bloat and deprecates the preference
> MenuLabelSet.
>
> Note: may break some CJK translations.
>
> Modified Files
> src/af/xap/xp/xap_Menu_Layouts.h
> src/wp/ap/xp/ap_Menu_Id.h
> src/wp/ap/xp/ap_Menu_Layouts.cpp
> src/wp/ap/xp/ap_String_Id.h
> /user/wp/strings/[Many Files].strings
>
>
> Added Files
> src/wp/ap/xp/ap_Menu_Id_List.h
>
>
>
>
This archive was generated by hypermail 2b25 : Tue Oct 30 2001 - 20:19:18 CST