commit: Re: commit: Fix 6143 / problems

From: msevior_at_physics.unimelb.edu.au
Date: Sat Jan 03 2004 - 16:53:07 EST

  • Next message: Marc Maurer: "Re: Quick hello and a patch? if you want it."

    > En/na msevior_at_physics.unimelb.edu.au ha escrit:
    >
    >> CVS:
    >> ----------------------------------------------------------------------
    >> CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    >> CVS:
    >> CVS: Committing in .
    >> CVS:
    >> CVS: Modified Files:
    >> CVS: wp/impexp/xp/ie_imp.cpp wp/impexp/xp/ie_imp.h
    >> CVS: wp/impexp/xp/ie_imp_Text.cpp
    >> CVS:
    >> ----------------------------------------------------------------------
    >> Fix 6143 paste text bug.
    >>
    >> I *think* I fixed the problem. We weren't testing for pasting when
    >> importing text. Please test and see if it's fully fixed.
    >>
    >> This should be back ported.
    >
    > Martin,
    >
    > When you cut and paste a piece of plain text from one Windows applications
    > into Abiword HEAD or STABLE is crashes. I strongly think that this crash
    > is
    > due to the changes that you introduced to fix 6143.
    >
    > At member bool IE_Imp::appendStruxFmt when you execute:
    >
    > bRes = m_pDocument->changeStruxFmt(PTC_AddFmt, m_dpos,
    > m_dpos,
    > attributes, NULL, pfs->getStruxType());
    >
    > The variable pfs is not init (:- It's very easy to reproduce. You want me
    > to
    > open a bug report?
    >

    Hi Jordi,
             Whoops! You're right.

    I'll commit a fix now.

    Martin

    CVS: ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: ie_exp_HTML.cpp ie_imp.cpp ie_imp_Text.cpp
    CVS: ----------------------------------------------------------------------
    Full fix for 6143, fix for incorrect assert in exp_HTML.

    > Thanks,
    >
    > Jordi,
    >
    >
    > --
    >
    > Jordi Mas i Hernāndez (homepage http://www.softcatala.org/~jmas)
    > http://www.softcatala.org
    >
    >
    >

    This archive was generated by hypermail 2.1.4 : Sat Jan 03 2004 - 16:52:18 EST