Re: fix for abicocoa

From: R. Payette <premi_at_altern.org>
Date: Tue Oct 05 2004 - 22:04:12 CEST

Here... no need to modify gr_Graphics.cpp

fix :
-1 px offset of left ruler, top ruler and document
- caret blinking smudge
- top ruler smudge ( this one was also in my previous patch )

there was a define #define TDUX(x) (_tduX(x)+1.0) in gr_CocoaGraphics
that, I guess used serve a purpose but with the other modifications, as
far as I can tell, it's no more required.

Le 04-10-05, à 15:28, J.M. Maurer a écrit :

>
>> and I'd like to know from more experienced dev, what would be the best
>> way to archive this:
>>
>> in gr_Graphics.cpp
>>
>> UT_sint32 GR_Graphics::_tduX(UT_sint32 layoutUnits) const
>> {
>> return tdu(layoutUnits+getPrevXOffset()) - tdu(getPrevXOffset())-1;
>> }
>>
>> adding the -1 at the end fixes a few display bugs on the cocoa port
>> but
>> I'm pretty sure it not the right way to do it, other ports will be
>> broken by that.
>
> Don´t know if this has been anwered already (my mail access sucks
> atm), but
> adding -1 is definately not right. For now, stick with the last litle
> errors
> remaining (if there isn´t another fix for them), as I´m reworking all
> this tdu
> stuff. When I commit that, all _should_ work just right. If not, then
> there is
> a bug elsewhere :)
>

Received on Tue Oct 5 22:04:48 2004

This archive was generated by hypermail 2.1.8 : Tue Oct 05 2004 - 22:04:48 CEST