Re: commit (head): 8393

From: Tomas Frydrych <tomasfrydrych_at_yahoo.co.uk>
Date: Mon Apr 11 2005 - 08:50:11 CEST

Hubert Figuiere wrote:
> This is wrong: UT_String should be avoided AT ALL COST.

This is nonsense and we have been through this again and again on the
list; UT_UTF8String can only represent utf8 strings, it cannot represent
generic 8-bit strings.

> What should have been done is changing
> s = pSS->getValue(...);
> By
> s = pSS->getValueUTF8(...);

Well, not all platforms use utf8 internally and it seems make more sense
to leave the string in AW locale and have the platform code *that
requires* utf8 to do the conversion than to do abi-locale -> utf8 ->
abi-locale on Windows. What is worse, your commit reintroduced this bug,
because the m_pDocLanguage is not a utf8 string, but a string in AW
locale; this is not hard to fix, but I do not have the time.

Tomas
Received on Mon Apr 11 08:53:04 2005

This archive was generated by hypermail 2.1.8 : Mon Apr 11 2005 - 08:53:05 CEST