Re: commit (head): more pango stuff

From: Tomas Frydrych <tomasfrydrych_at_yahoo.co.uk>
Date: Wed Feb 16 2005 - 21:31:52 CET

J.M. Maurer wrote:
> Op wo, 16-02-2005 te 18:51 +0000, schreef Tomas Frydrych:
>
>>some more work on the Pango graphics class (gr_UnixPangoGraphics.cpp).
>>Because Pango currently does not support justification, we will need to
>>apply the same technique the default graphics uses (expanding spaces)
>>and this requires some changes in fp_TextRun.cpp.
>
>
> Ick!
>
> #ifdef XP_UNIX_TARGET_GTK in xp code! Do we really want that ?
>
> Marc

The assumption is that this is a temporary hack until Pango implements
justification. For now I need to give the Pango class access to the raw
text in those two functions and this adds some overhead due to the
construction of the text iterator. While the overhead is not huge, these
things tend to cumulate, and so I thought it better not to do that for
win32 and the Mac (the ifdef also reminds me that this is a hack that
should be removed when possible). However, if people dislike it too
much, I can remove the ifdef.

Tomas
Received on Wed Feb 16 21:32:38 2005

This archive was generated by hypermail 2.1.8 : Wed Feb 16 2005 - 21:32:39 CET