Re: CVS: commit dom abiword-plugins/tools/abicommand/xp AbiCommand.cpp

On Sat, 2005-10-22 at 16:30 -0700, Dom Lachowicz wrote:
> > Erm, why reindent, especially when it is breaking
> > our own style
> > guidelines?
>
> *) The code there didn't conform to our style
> guidelines anyway.
> *) 99.99% of our code doesn't conform to our own style
> guidelines.
> *) I couldn't deal with the code as it was. Even
> though the current revision doesn't conform to our
> guidelines, it is an improvement. At least it's
> internally consistent.
> *) Coding guidelines not reproducible by GNU's
> "indent" are not worth following.

*) Using spaces instead of tabs sucks massively when you don't have an
editor to do that easily (yes, i use those over terminals from time to
time)

*) Nothing can justify b0rked indentation like

if (foo)
  {
      if (bar)
        {
        }
  }

Marc
Received on Sun Oct 23 01:35:51 2005