On 8/9/06, Erik Pukinskis <erik@snowedin.net> wrote:
> Rob,
>
> I have a patchset ready that adds the clipart bar to the Sugar branch,
> and has a few other tweaks (toolbar on the bottom, buttons changed,
> etc)... should I go ahead and commit? the relevant files are
> attached.
The diff looks good, except for the BOTTOM_TOOLBAR define. Couldn't
that just be HAVE_SUGAR?
About ap_ClipartPane* i'm not sure where it will go to. Isn't that a
baseclass in XAP Land (which would require renaming for consistency)?
Sorry for the superficial quickie review, will be on holiday 'til
Wednesday next week and quite possibly not have much spare time to
work on abi/sugar before that.
Best,
Rob
This archive was generated by hypermail 2.1.8 : Wed Aug 09 2006 - 09:46:04 CEST