Re: rp - r21634 - in abiword-plugins/trunk/tools/abicollab: backends/tcp/win core/dialogs/win core/session/xp

From: <sum1_lists_at_yahoo.com>
Date: Mon Jul 23 2007 - 08:00:45 CEST

cvs@abisource.com wrote:
> Log:
> Ryan Pavlik SoC - Enable TCP backend, GUI for Add Account and TCP
backend
>
> More dialogs, and now programmatically-created elements courtesy of
the TCP backend! Plus, the bug fixes and enhancements to
implementation in the rest of the works to get this to work.
>
> Modified:
abiword-plugins/trunk/tools/abicollab/backends/tcp/win/TCPWin32AccountHandler.cpp
> ===================================================================
> ---
abiword-plugins/trunk/tools/abicollab/backends/tcp/win/TCPWin32AccountHandler.cpp
2007-07-23 02:35:23 UTC (rev 21633)
> +++
abiword-plugins/trunk/tools/abicollab/backends/tcp/win/TCPWin32AccountHandler.cpp
2007-07-23 05:13:08 UTC (rev 21634)
> @@ -35,102 +35,75 @@
> }
>
> TCPWin32AccountHandler::TCPWin32AccountHandler()
> - : TCPAccountHandler()
> + : TCPAccountHandler(),
> + m_hBox(NULL),
> + m_hServerEntry(NULL),
> + m_hPortEntry(NULL),
> + m_hServerRadio(NULL),
> + m_hJoinRadio(NULL),
> + m_hServerLabel(NULL),
> + m_hPortLabel(NULL),
> + m_hAutoconnectCheck(NULL),
> + m_hUseSecureCheck(NULL)
> {
> + AbiCollabSessionManager * pSessionManager=
AbiCollabSessionManager::getManager();
> + UT_return_if_fail(pSessionManager);
> + m_hInstance=pSessionManager->getInstance();
>
[snip]
> -
> - vbox = gtk_vbox_new(FALSE, 6);
> - GtkVBox* parent = (GtkVBox*)pEmbeddingParent;
> + m_hServerEntry = CreateWindow("EDIT", "", ES_LEFT | WS_CHILD |
WS_VISIBLE | WS_BORDER | WS_TABSTOP,
> + 66, 71, 121, 14, m_hBox, NULL, m_hInstance, NULL);

It looks like m_hInstance will be uninitialized if pSessionManager is
NULL in the constructor above.

       
____________________________________________________________________________________
Pinpoint customers who are looking for what you sell.
http://searchmarketing.yahoo.com/
Received on Mon Jul 23 08:02:17 2007

This archive was generated by hypermail 2.1.8 : Mon Jul 23 2007 - 08:02:18 CEST