Re: uwog - r21390 - abiword-plugins/trunk/wp/impexp/OpenDocument/exp/xp

On Thu, 2007-06-07 at 09:01 +0300, Dominic Lachowicz wrote:
> What's up with this commit, Marc?

Without it, AbiWord crashes in gsf (see
http://dev.laptop.org/ticket/1468)

> As far as I can tell, the following
> change makes the mimetype file compressed in the ZIP archive. This is
> verboten in the ODT specification, since external programs use the
> mimetype to distinguish between ODTs and normal ZIPs.
>
> > - GsfOutput * mimetype = gsf_outfile_new_child_full (m_odt, "mimetype", FALSE, "compression-level", 0, (void*)0);
> > + GsfOutput * mimetype = gsf_outfile_new_child_full (m_odt, "mimetype", FALSE, "compression-level");

Given that there is no documentation whatsoever on gsf and what that
"firstproperty" thing does, I'm not sure it is the right fix.

Any better solution in mind?

Thanks for the review :)
  Marc
Received on Thu Jun 7 10:21:54 2007