On Tue, Jul 28, 2009 at 9:57 PM, Keith Bowes<zooplah@gmail.com> wrote:
>>
>> Would be good if you also stated what the changes were. (You might be
>> able to annoy them a bit more.)
>>
>
> Eh, I probably shouldn't have included uwog there. He's not so bad.
> But since hub apparently gets annoyed by every commit I make, it
> didn't stand to reason that this would have been the exception. Also
> not surprisingly, he reacted to be passive-aggressive commit message
> with a threat.
>
> I didn't do much. I got the dependencies for all the plugins that
> were compiling in Linux downloaded and verified that they'd compile
> (only goffice, mathview, and ots had any problems; alright, gimp had a
> small problem, but nothing that prevented it from being compiled or
> ran), I did a couple of fixes for Win32 and Cocoa (removed references
> to AP_BuiltinStringSet and AP_DiskStringSet), I added a couple plugin
> Makefiles that somehow weren't added before, and I think that's about
> it.
I don't care about you taking humor or pet peeves to commit messages
as long as it's harmless, like above. What I wanted to say is that you
should ALSO describe the actual changes, so I have an easier time
looking at the diff.
- Rob
Received on Wed Jul 29 08:40:53 2009
This archive was generated by hypermail 2.1.8 : Wed Jul 29 2009 - 08:40:53 CEST