Re: imdonatello - r26639 - abiword/branches/gsoc2009tablelayout/src/text/fmt/xp

Just some style comments, for the record

On 05/30/2009 03:54 PM, cvs@abisource.com wrote:

> + UT_sint32 extra_width = m_MyAllocation.width - m_MyRequest.width,
> + expandable_cols = getNumCols() - pVecColProps->getItemCount(),
> + rem, quo;

Don't do that, mixing declaration and initialisation. This is unreadable.
If you declare and initialize at once, do it one at at a time.

> + rem = ((rem> 0)? rem-- : 0);

You can make that one clearer by using if()
This is too obfuscated, therefor unnecessary

Thanks,

Hub
Received on Sat May 30 22:05:37 2009