Re: urmaslt - r29620 - abiword/trunk/plugins/mswrite/xp

From: Ingo Brückl <ib_at_wupperonline.de>
Date: Fri Jul 15 2011 - 20:12:16 CEST

J.M. Maurer wrote on Fri, 08 Jul 2011 17:39:47 +0200:

> could you help us out and point us to the relevant change(s) that
> need to be made to get the plugin to work again?

Here you are. Please see the attached patch.

From the current codebase of the MSWrite plugin (based on last change made in
r29667) there are some indent changes in read_pap() which blow up the patch.

I started my work with the pre-r29620 codebase after having applied my
original "complete support for all possible picture types" patch, examining
all repository changes since then.

The codepage code has been revised, greatly simplified and (to be worth the
effort) completed by adding the missing font substitutes.

Large parts of r29645 are reverted now and - instead - the whole
header/footer stuff has been completely rewritten. (Who did that patch? I
cannot remember having seen a patch proposal here.) The plugin now has *full*
support of headers and footers, including page number, starting number,
margins, formatting and appearance (or not) on the first page.

Assuming that Abi the Ant isn't a real person, I registered Sean and me as
authors of the plugin. If someone else did some *major* work on the plugin
prior to r28948 (couldn't find one in the log), then his/her name should be
inserted between the two of us.

As always, I did extensive testings and can ensure that everything works fine
now. (Well, only if the patch gets applied exactly as it is this time. If
there are issues, please tell me.)

Ingo

Received on Fri, 15 Jul 2011 20:12:16 +0200

This archive was generated by hypermail 2.1.8 : Fri Jul 15 2011 - 20:38:30 CEST