Urmas wrote on Sat, 16 Jul 2011 05:37:06 +0700:
> First, there's a golden rule: one change, one patch.
Is that why you previously merged two patches, screwed them up and applied
them?
And, if you want to talk about commit rules. A patch usually comes with a
detailed and informative commit message and the author of the patch is
mentioned with full name and obfuscated email address.
The job of a committer is to either apply a patch as it is or to reject it
with an exemplary explanation why, so that it can be discussed and fixed.
Everything else is disrespectful and a puts the patch at risk. (And merging
own changes in is totally unworthy of discussion!)
> You didn't state what was a problem first time, nor how you did fix it.
Maybe simply that the plugin suddenly crashed and now is working fine again
with additional features?
Received on Sat Jul 16 13:49:10 2011
This archive was generated by hypermail 2.1.8 : Sat Jul 16 2011 - 13:49:10 CEST