Re: monkeyiq - r30057 - in abiword/trunk: plugins/opendocument/imp/xp src/af/util/xp

On Mon, 2011-07-18 at 20:33 -0700, Hubert Figuiere wrote:
> On 11-07-18 5:03 PM, cvs@abisource.com wrote:
> > +UT_UCS4Char* UT_UCS4String::begin() const
> > +{
> > + return pimpl->size() ? pimpl->data() : 0;
> > +}
> > +
> > +UT_UCS4Char* UT_UCS4String::end() const
> > +{
> > + UT_UCS4Char* b = begin();
> > + if( !b )
> > + return b;
> > +
> > + std::advance( b, length() );
> > + return b;
> > +}
>
> Shouldn't this return a const UT_UCS4Char * instead? Since "this" is
> immutable, its content should be too.

Ah yes, nice catch!

I think I started out with const UT_UCS4Char * on the const method, and
started playing... :O I'll commit a fix now.

>
>
> Hub