Re: ib - r30466 - abiword/trunk/plugins/mswrite/xp

From: Fridrich Strba <fridrich.strba_at_bluewin.ch>
Date: Fri Nov 18 2011 - 06:22:57 CET

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On 18/11/11 05:27, Hub Figuière wrote:
>>>> - if (process == All) UT_DEBUGMSG(("PAP:\n")); + if
>>>> (process == All) { UT_DEBUGMSG(("PAP:\n")) };
>>
>>> Since you are at fixing the braces (good), please fix the
>>> indentation too.
>>
>> Not for these one line debug messages. This would worsen
>> readability.
>
> I disagree. What worsen readability is a if without trailing
> block....

I support Hub in this. Maybe here it is not so obvious, but if there
were several of those following each other it would be a royal PITA to
read.

F.
Received on Fri Nov 18 06:23:38 2011

This archive was generated by hypermail 2.1.8 : Fri Nov 18 2011 - 06:23:38 CET