RDF UI support (was: Re: hub - r30565 - in abiword/trunk/src: af/ev/cocoa af/xap/cocoa wp/ap/cocoa)

>> No deal: http://pastebin.com/KUsztKeu
>> But don't worry. I'm without my mac until I finish my moving, so I
>> can't help so much.\
>
> That's a different error.

Here s the error:

   CXXLD libabiword-2.9.la
Undefined symbols:
   "runInsertReferenceDialog(FV_View*)", referenced from:
       ap_EditMethods::rdfInsertRef(AV_View*, EV_EditMethodCallData*)
     in libxp.a(ap_EditMethods.o)
   "runSemanticStylesheetsDialog(FV_View*)", referenced from:
       ap_EditMethods::rdfStylesheetSettings(AV_View*,
EV_EditMethodCallData*) in libxp.a(ap_EditMethods.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status

>
> I think it is RDF support that does that.

Congrats for opening the can of worm. That's where a bug needs to be filed.

Here is the issues:

- The ap_EditMethods are compiled in even when RDF support isn't. BAD

- runInsertReferenceDialog() and runSemanticStylesheetsDialog() are
implemented in src/text/ptbl/xp/pd_DocumentRDF.cpp which isn't compiled
when RDF support isn't. GOOD

- these two function don't belong in pd_DocumentRDF.cpp. UI do NOT
beling the PD_*. Gtk code do not belong to "xp" code. BAD and BAD.

Two fixes need to happen:

- the simple on is to fix ap_EditeMethods to not compile RDF methods in.

- the more complex in is pulling all this UI code out of pd_DocumentRDF
to, I believe, XAP, or AP if it is easier.

Cheers,

Hub

Hub
Received on Sat Feb 11 07:55:07 2012