On Mon, 2012-02-13 at 13:14 +1000, Ben Martin wrote:
> On Sun, 2012-02-12 at 19:09 -0800, Hub Figuière wrote:
> > On 12/02/12 06:53 PM, Ben Martin wrote:
> > > Hi,
> > > In configure.in I have a test for champlain-gtk-0.12.
> > >
> > > looking at configure.in I see a check with the following fragment:
> > >
> > > champlain_req=' champlain-gtk-0.12 '
> > > ...
> > > PKG_CHECK_MODULES(CHAMPLAIN, [ $champlain_req ],
> > >
> > > In src/Makefile.am I link with CHAMPLAIN if it is found in the
> > > libabiword_@ABIWORD_SERIES@_la_LDFLAGS target.
> > >
> > > I'm not sure which changes are needed to better detect and optionally
> > > use champlain if found. I'm happy to make any needed changes.
> >
> >
> > The problem lies down to the fact the libchamplain seems to not
> > distinguish linking against gtk2 or gtk3, and will drag whichever it is
> > linked against. I don't know whether they support both version or just
> > one, but if they support one it might be interesting to know which is
> > the cut-off and use that depending on the requested version of gtk.
>
> I've got a little configure.in magic for that part, committing soon.
>
ok, r30638 introduces a little test for that. If we are building gtk3
and libchamp is linked to gtk2 then we should no longer try to build
champ support (as it will fail).
> >
> > Also I do believe that this also do NOT belong to XP code nor to "PD_".
>
> Definitely. I will be moving that gui part out of there shortly.
>
This archive was generated by hypermail 2.1.8 : Mon Feb 13 2012 - 04:51:21 CET