Re: vincent - r31546 - abiword/branches/gsoc2012dialogs/src/wp/ap/cocoa

On 23/07/12 09:32 AM, cvs@abisource.com wrote:
>
> Author: vincent
> Date: 2012-07-23 18:32:29 +0200 (Mon, 23 Jul 2012)
> New Revision: 31546
>
> Modified:
> abiword/branches/gsoc2012dialogs/src/wp/ap/cocoa/ap_CocoaDialog_FormatTable.cpp
> abiword/branches/gsoc2012dialogs/src/wp/ap/cocoa/ap_CocoaDialog_FormatTable.h
> Log:
> IBOutlet and IBAction define
>
> Modified: abiword/branches/gsoc2012dialogs/src/wp/ap/cocoa/ap_CocoaDialog_FormatTable.cpp
> ===================================================================
> --- abiword/branches/gsoc2012dialogs/src/wp/ap/cocoa/ap_CocoaDialog_FormatTable.cpp 2012-07-23 16:30:31 UTC (rev 31545)
> +++ abiword/branches/gsoc2012dialogs/src/wp/ap/cocoa/ap_CocoaDialog_FormatTable.cpp 2012-07-23 16:32:29 UTC (rev 31546)
> @@ -114,6 +114,35 @@
> [m_dlg->_thicknessPopup selectItemAtIndex:closest];
> }
>
> +void AP_CocoaDialog_FormatTable::setHeightInGUI(UT_UTF8String & /*sHeight*/)
> +{
> + UT_ASSERT_NOT_REACHED();
> +}
> +
> +void AP_CocoaDialog_FormatTable::setWidthInGUI(UT_UTF8String & /*sWidth*/)
> +{
> + UT_ASSERT_NOT_REACHED();
> +}
> +- (IBAction)tableHeightField:(id)sender;
> +{
> +
> +}

This does NOT compile because you put the Objective-C method out of the
@implementation section.

Committing code that does not compile is not good.

Hub
Received on Mon Jul 23 19:04:57 2012