Re: vincent - r31337 - abiword/branches/gsoc2012dialogs/src/wp/ap/xp

Hi Vincent,
Can we have an update on your progress? I can see a few commits - but
I just would love to see a quick higher level progress update to see
how far have we progressed, against our initial plan. As agreed upon,
a weekly update would be preferred.

We have less than one month for the mid-evaluations, and I suspect, we
are lagging behind the schedule severely.

Thank you.
Regards,
Pradeeban.

On Fri, Jun 8, 2012 at 3:18 PM, <cvs@abisource.com> wrote:
>
> Author: vincent
> Date: 2012-06-08 11:48:09 +0200 (Fri, 08 Jun 2012)
> New Revision: 31337
>
> Modified:
>   abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.cpp
>   abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.h
>   abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.cpp
>   abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.h
> Log:
> make function inline
>
> Modified: abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.cpp
> ===================================================================
> --- abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.cpp     2012-06-07 16:15:34 UTC (rev 31336)
> +++ abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.cpp     2012-06-08 09:48:09 UTC (rev 31337)
> @@ -1049,16 +1049,6 @@
>        m_bSettingsChanged = true;
>  }
>
> -float AP_Dialog_FormatFrame::getFrameWidth(void)
> -{
> -       return m_width;
> -}
> -
> -float AP_Dialog_FormatFrame::getFrameHeight(void)
> -{
> -       return m_height;
> -}
> -
>  void AP_Dialog_FormatFrame::setBorderColorRight (const UT_RGBColor & clr)
>  {
>        m_borderColorRight = clr;
>
> Modified: abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.h
> ===================================================================
> --- abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.h       2012-06-07 16:15:34 UTC (rev 31336)
> +++ abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.h       2012-06-08 09:48:09 UTC (rev 31337)
> @@ -184,8 +184,8 @@
>        float                                   borderThicknessLeft ()   const { return m_borderThicknessLeft;   }
>        float                                   borderThicknessTop ()    const { return m_borderThicknessTop;    }
>        float                                   borderThicknessBottom () const { return m_borderThicknessBottom; }
> -       float                   getFrameWidth(void);
> -       float                   getFrameHeight(void);
> +       inline float            getFrameWidth() const {  return m_width; }
> +       inline float            getFrameHeight() const { return m_height; }
>
>        void                                    setPositionMode (FL_FrameFormatMode mode);
>
>
> Modified: abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.cpp
> ===================================================================
> --- abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.cpp     2012-06-07 16:15:34 UTC (rev 31336)
> +++ abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.cpp     2012-06-08 09:48:09 UTC (rev 31337)
> @@ -683,16 +683,6 @@
>        return _getToggleButtonStatus("left-style");
>  }
>
> -float AP_Dialog_FormatTable::getTableWidth(void)
> -{
> -       return m_width;
> -}
> -
> -float AP_Dialog_FormatTable::getTableHeight(void)
> -{
> -       return m_height;
> -}
> -
>  guint AP_Dialog_FormatTable::_findClosestThickness(const char *sthickness) const
>  {
>        double thickness = UT_convertToInches(sthickness);
>
> Modified: abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.h
> ===================================================================
> --- abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.h       2012-06-07 16:15:34 UTC (rev 31336)
> +++ abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatTable.h       2012-06-08 09:48:09 UTC (rev 31337)
> @@ -122,8 +122,8 @@
>        bool                                                            getLeftToggled();
>        GR_Image *                          getImage(void) { return m_pImage;}
>        FG_Graphic *                        getGraphic(void) { return m_pGraphic;}
> -       float                               getTableWidth(void);
> -       float                               getTableHeight(void);
> +       inline float                        getTableWidth(void) { return m_width; }
> +       inline float                        getTableHeight(void) { return m_height; }
>
>        UT_RGBColor                                                     m_borderColor;
>        UT_sint32                                                       m_lineStyle;
>
> -----------------------------------------------
> To unsubscribe from this list, send a message to
> abisource-cvs-commit-request@abisource.com with the word
> unsubscribe in the message body.

-- 
Kathiravelu Pradeeban.
Blog: [Llovizna] http://kkpradeeban.blogspot.com/