Re: ATTN: AbiWord 2.5.0 released

On Mon, 15 Jan 2007 09:23:04 +0100
Robert Staudinger wrote:

> If you make such assumptions please post them to the -dev mailing list
> so the can be rebutted accordingly. Citing the relevant code below.
> - Rob

My apologies I simply hit reply and the mailer sent it to this list.
 
> @if test -f $(DESTDIR)/$(bindir)/abiword; then \
> echo "$(DESTDIR)/$(bindir)/abiword is a regular file - I'm
> not going to create a link."; \
> else \
> (cd $(DESTDIR)/$(bindir) && ln -sf $(ABIWORD_BINARY)
> abiword); \ fi

The above is not effective if build is done in an rpm environment using
BuildRoot: %_tmppath/%oname-%version-buildroot

The test will only check if $(bindir)/abiword exist in
%_tmppath/abiword-2.5.0-buildroot/usr/bin/
which it won't and so the link will always be created and must be
removed within the rpm spec
rm -f $RPM_BUILD_ROOT%{_bindir}/%{oname}

    Charles

-- 
"I wouldn't give it to a dog, and I *am* one."
        -- Gaspode the wonder dog
           (Terry Pratchett, Moving Pictures)
----------------------
Mandriva Linux release 2007.0 (Official) for i586$
Registered Linux user #182463 on TallBoy....http://www.eslrahc.com
2.6.19.2-tmb-desktop-1mdv-i586 AMD Athlon(tm) XP 3200+
----------------------

-----------------------------------------------
To unsubscribe from this list, send a message to
abiword-user-request@abisource.com with the word
unsubscribe in the message body.